Skip to content

[19.0][MIG] edi_product_oca: Migration to 19.0#287

Open
yankinmax wants to merge 9 commits into
OCA:19.0from
camptocamp:19.0-mig-edi_product_oca
Open

[19.0][MIG] edi_product_oca: Migration to 19.0#287
yankinmax wants to merge 9 commits into
OCA:19.0from
camptocamp:19.0-mig-edi_product_oca

Conversation

@yankinmax
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM

In the GUI, I noticed that the edi_disable_auto field is displayed oddly. It was already slightly off-screen in v18, but now the rendering looks very strange:

18.0

Image

19.0

Image

Could you align if to the left ? 🙏

@yankinmax yankinmax force-pushed the 19.0-mig-edi_product_oca branch 3 times, most recently from 3c0f3fe to c2f1d18 Compare May 25, 2026 07:50
@yankinmax
Copy link
Copy Markdown
Contributor Author

@Ricardoalso fixed

Comment thread edi_product_oca/__manifest__.py Outdated
"website": "https://github.com/OCA/edi-framework",
"depends": [
"product",
"edi_endpoint_oca",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency is wrong as is coming from v18. It must be fixed there too.
It should be only edi_core_oca.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration commit LG

@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="utf-8" ?>
<odoo>
<record id="uom_uom_form_view" model="ir.ui.view">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="uom_uom_form_view" model="ir.ui.view">
<record id="uom_uom_form_view_inherit" model="ir.ui.view">

@@ -0,0 +1,9 @@
# Copyright 2024 Camptocamp SA
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2024 Camptocamp SA
# Copyright 2026 Camptocamp SA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants