[17.0][ADD] mail_activity_plan_domain: New Module#182
Open
cristina-hidalgo-tecnativa wants to merge 1 commit into
Open
[17.0][ADD] mail_activity_plan_domain: New Module#182cristina-hidalgo-tecnativa wants to merge 1 commit into
cristina-hidalgo-tecnativa wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:17.0
mod:mail_activity_plan_domain
victoralmau
suggested changes
Apr 16, 2026
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
IMO, the best approach is to use the same method that mail already has in version 18.0: https://github.com/odoo/odoo/blob/754898c58fded0e3c3c30702f15258f1dadcfa6c/addons/mail/models/mail_activity_plan.py#L30 and add to ROADAMP that it is only necessary up to 17.0; in addition, it would also be necessary to add to OpenUpgrade that this new module is no longer required.
pedrobaeza
reviewed
Apr 16, 2026
Member
|
@victoralmau I don't get your comment. This one is for having a domain inside the model, not a model restriction. |
cristina-hidalgo-tecnativa
force-pushed
the
17.0-add-mail_activity_plan_domain
branch
3 times, most recently
from
9cce30c to
9f10ef4
Compare
victoralmau
approved these changes
Jun 2, 2026
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Code review OK.
These comments are just suggestions:
- I don't think the
usersdecorator is necessary. - It would be helpful to add
assertInandassertNotInto all plans to confirm whether or not they are available in the different tests.
cristina-hidalgo-tecnativa
force-pushed
the
17.0-add-mail_activity_plan_domain
branch
from
9f10ef4 to
6726d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modules adds a
filter_domainfield to activity plans and their templates. Plans only appear in the scheduling wizard when the active record matches the plan domain. During execution, activities whose template domain does not match the record are silently skipped, allowing a single plan to handle heterogeneous records.@Tecnativa TT61908
@pedrobaeza @victoralmau