[19.0][MIG] project_tag_security: Migration to 19.0 by stferraro · Pull Request #1712 · OCA/project

stferraro · 2026-04-23T22:55:40Z

No description provided.

TT51195 [UPD] Update project_tag_security.pot [BOT] post-merge updates

Translated using Weblate (Italian) Currently translated at 100.0% (3 of 3 strings) Translation: project-16.0/project-16.0-project_tag_security Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_tag_security/it/

TT55551

Currently translated at 100.0% (6 of 6 strings) Translation: project-18.0/project-18.0-project_tag_security Translate-URL: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_tag_security/sv/

Related to OCA#1449 (comment)

WesleyOliveira98

Missing pre-commit auto-fixes commit
It's necessary to squash your last 2 commits into one
The PR title is not following the OCA patterns
Check: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

WesleyOliveira98

The PR title stll not following the OCA patterns, should be:
[19.0][MIG] <module>: Migration to 19.0

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#how-to

WesleyOliveira98

@stferraro you need to change the PR title to [19.0][MIG] <module>: Migration to 19.0, the commit title was correct, should be [MIG] <module>: Migration to 19.0

Everything else is ok, just change this

WesleyOliveira98

In your PR, click on this button:

Insert the title: [19.0][MIG] project_tag_security: Migration to 19.0
Click on save

Then, change the commit message to: [MIG] project_tag_security: Migration to 19.0

stferraro · 2026-04-28T19:53:42Z

@CristianoMafraJunior please check this!

CristianoMafraJunior · 2026-04-28T19:57:06Z

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+{
+    "name": "Project Tag Security",
+    "version": "19.0.1.0.1",


WesleyOliveira98

LGTM

OCA-git-bot · 2026-04-28T23:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

luisDIXMIT

Code review and tested on runboat, LGTM!

leemannd · 2026-05-04T08:22:42Z

/ocabot migration project_tag_security

Yusuke1998

LGTM!

Karla-Villegas

Functional tests: Approved.

BhaveshHeliconia

LGTM!

stferraro · 2026-05-21T13:03:45Z

@OCA-git-bot ping

leemannd · 2026-05-21T13:24:09Z

@OCA-git-bot ping

Hello @stferraro I don't know this. I'm not sure it does anything

leemannd · 2026-05-21T13:24:41Z

/ocabot merge nobump

OCA-git-bot · 2026-05-21T13:24:52Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1712-by-leemannd-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-21T13:27:58Z

@leemannd your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1712-by-leemannd-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

stferraro · 2026-05-21T13:47:51Z

/ocabot merge nobump

leemannd · 2026-05-21T14:09:26Z

There is an error when trying to merge it

2026-05-21 13:27:29,168 335 INFO odoo odoo.addons.project_task_description_template.tests.test_project_task: Starting TestDescriptionTemplate.test_onchange_description_template_id ... 
2026-05-21 13:27:29,193 335 INFO odoo odoo.addons.project_task_description_template.tests.test_project_task: ====================================================================== 
2026-05-21 13:27:29,193 335 ERROR odoo odoo.addons.project_task_description_template.tests.test_project_task: FAIL: TestDescriptionTemplate.test_onchange_description_template_id
Traceback (most recent call last):
  File "/__w/project/project/project_task_description_template/tests/test_project_task.py", line 22, in test_onchange_description_template_id
    self.assertEqual(
AssertionError: Markup('<p>Existing Description</p><span>- Sample Description</span>') != Markup('<p>Existing Description</p><p>- Sample Description</p>') : Onchange method failed to append description correctly.
 
2026-05-21 13:27:29,194 335 INFO odoo odoo.addons.project_task_description_template.tests.test_project_task: Starting TestDescriptionTemplate.test_onchange_with_empty_description ... 
2026-05-21 13:27:29,198 335 INFO odoo odoo.addons.project_task_description_template.tests.test_project_task: ====================================================================== 
2026-05-21 13:27:29,198 335 ERROR odoo odoo.addons.project_task_description_template.tests.test_project_task: FAIL: TestDescriptionTemplate.test_onchange_with_empty_description
Traceback (most recent call last):
  File "/__w/project/project/project_task_description_template/tests/test_project_task.py", line 32, in test_onchange_with_empty_description
    self.assertEqual(
AssertionError: Markup('<span>- Sample Description</span>') != Markup('<p>- Sample Description</p>') : Onchange method failed with empty initial description.```

leemannd · 2026-05-21T14:09:54Z

@stferraro do you have time to have look at it?

stferraro · 2026-05-21T14:42:12Z

@leemannd

Suggested Fix:
Please update the expected assertion value from 18 to 19 in both test methods (around lines 119 and 224). Also, there is a small typo in line 107: "A Should have A subtasks" which could be cleaned up to "A Should have 9 subtasks".
Thanks for your work on this! in test!

victoralmau and others added 11 commits April 23, 2026 18:09

[ADD] project_tag_security: New module

62d790d

TT51195 [UPD] Update project_tag_security.pot [BOT] post-merge updates

[IMP] project_tag_security: pre-commit auto fixes

c8f72dc

[MIG] project_tag_security: Migration to 18.0

2f54b15

TT55551

[UPD] Update project_tag_security.pot

c8ded82

[BOT] post-merge updates

d12e7ed

Added translation using Weblate (Portuguese (Brazil))

dec20c2

Added translation using Weblate (Swedish)

b478131

Translated using Weblate (Swedish)

eb10c60

Currently translated at 100.0% (6 of 6 strings) Translation: project-18.0/project-18.0-project_tag_security Translate-URL: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_tag_security/sv/

[IMP] project_tag*: Remove auto_install=True

2761da0

Related to OCA#1449 (comment)

[BOT] post-merge updates

0124f8c

OCA-git-bot added series:19.0 mod:project_tag_security Module project_tag_security labels Apr 23, 2026

stferraro mentioned this pull request Apr 23, 2026

Migration to version 19.0 #1571

Open

42 tasks

WesleyOliveira98 suggested changes Apr 25, 2026

View reviewed changes

stferraro force-pushed the 19.0-mig-project_tag_security branch from 29302a2 to c937a29 Compare April 26, 2026 02:41

stferraro requested a review from WesleyOliveira98 April 26, 2026 02:43

WesleyOliveira98 suggested changes Apr 27, 2026

View reviewed changes

stferraro force-pushed the 19.0-mig-project_tag_security branch from c937a29 to bcdd5f7 Compare April 28, 2026 01:00

stferraro requested a review from WesleyOliveira98 April 28, 2026 01:02

WesleyOliveira98 suggested changes Apr 28, 2026

View reviewed changes

stferraro force-pushed the 19.0-mig-project_tag_security branch from bcdd5f7 to 4671fd7 Compare April 28, 2026 12:52

stferraro requested a review from WesleyOliveira98 April 28, 2026 12:55

WesleyOliveira98 suggested changes Apr 28, 2026

View reviewed changes

stferraro changed the title ~~19.0 mig project tag security~~ [19.0][MIG] project_tag_security: Migration to 19.0 Apr 28, 2026

stferraro force-pushed the 19.0-mig-project_tag_security branch from 4671fd7 to c30977d Compare April 28, 2026 19:53

stferraro requested a review from WesleyOliveira98 April 28, 2026 19:53

CristianoMafraJunior suggested changes Apr 28, 2026

View reviewed changes

stferraro force-pushed the 19.0-mig-project_tag_security branch from c30977d to b3c3ef5 Compare April 28, 2026 20:10

stferraro requested a review from CristianoMafraJunior April 28, 2026 20:10

[MIG] project_tag_security: Migration to 19.0

8cfdb61

stferraro force-pushed the 19.0-mig-project_tag_security branch from b3c3ef5 to 8cfdb61 Compare April 28, 2026 20:13

CristianoMafraJunior approved these changes Apr 28, 2026

View reviewed changes

WesleyOliveira98 approved these changes Apr 28, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 28, 2026

luisDIXMIT approved these changes Apr 30, 2026

View reviewed changes

OCA-git-bot added this to the 19.0 milestone May 4, 2026

Yusuke1998 approved these changes May 7, 2026

View reviewed changes

Karla-Villegas approved these changes May 8, 2026

View reviewed changes

BhaveshHeliconia approved these changes May 19, 2026

View reviewed changes

leemannd approved these changes May 21, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 21, 2026

OCA-git-bot removed the bot is merging ⏳ label May 21, 2026

Uh oh!

Conversation

stferraro commented Apr 23, 2026

Uh oh!

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

Uh oh!

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

Uh oh!

WesleyOliveira98 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

Uh oh!

stferraro commented Apr 28, 2026

Uh oh!

CristianoMafraJunior Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

WesleyOliveira98 left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 28, 2026

Uh oh!

luisDIXMIT left a comment

Choose a reason for hiding this comment

Uh oh!

leemannd commented May 4, 2026

Uh oh!

Yusuke1998 left a comment

Choose a reason for hiding this comment

Uh oh!

Karla-Villegas left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

stferraro commented May 21, 2026

Uh oh!

leemannd commented May 21, 2026

Uh oh!

leemannd commented May 21, 2026

Uh oh!

OCA-git-bot commented May 21, 2026

Uh oh!

OCA-git-bot commented May 21, 2026

Uh oh!

stferraro commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leemannd commented May 21, 2026

Uh oh!

leemannd commented May 21, 2026

Uh oh!

stferraro commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

WesleyOliveira98 left a comment •

edited

Loading

stferraro commented May 21, 2026 •

edited

Loading