[18.0] [FIX] report_substitute: account.move.send.wizard report substitution#1149
Open
[18.0] [FIX] report_substitute: account.move.send.wizard report substitution#1149
Conversation
Contributor
|
Hi @sbejaoui, |
SodexisTeam
force-pushed
the
18.0-fix_report_substitute
branch
from
14a5f23 to
bd66fa5
Compare
Contributor
|
This PR has the |
lmignon
reviewed
Apr 16, 2026
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Are you sure that with this change the substitution are not ran 2 times in nomale cases? A first time in the _pre_render phase and a second time at _render?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description:
When sending emails from invoices, the substitution rules are not being applied as expected.
Resolution:
This PR addresses and resolves the issue by ensuring that the substitution rules are correctly applied during email generation from invoices.