8 add module external_file_location by bealdav · Pull Request #377 · OCA/server-tools

bealdav · 2016-02-25T21:08:31Z

This module allow the exchange of files with main protocols ftp, sftp.

The purpose of this module is not to import the data of the file (only exchange files).

Example of kind files which can use this module:

ecommerce: exchange with marketplace: ebay, amazon, etc.
logistics:
- send delivery order to logistics center, receive a delivery reply,
- send a notification of goods send to this center and collect a confirmation of good receiving of goods by the logistics
- collect inventory of the center
banking: receiving all documents ...

coveralls · 2016-05-26T14:27:39Z

Coverage increased (+2.7%) to 58.589% when pulling 513abeb on akretion:8-file-loc into 5571138 on OCA:8.0.

moylop260 · 2016-05-26T16:32:54Z

  - travis_install_nightly
  - printf '[options]\n\nrunning_env = dev\n' > ${HOME}/.openerp_serverrc
  - ln -s ${TRAVIS_BUILD_DIR}/server_environment_files_sample ${TRAVIS_BUILD_DIR}/server_environment_files
+  - pip install fs


What about add fs in requirements.txt?

coveralls · 2016-05-31T13:21:34Z

Coverage increased (+3.4%) to 59.239% when pulling b3e3af1 on akretion:8-file-loc into 5571138 on OCA:8.0.

coveralls · 2016-05-31T14:34:02Z

Coverage increased (+1.2%) to 59.239% when pulling ac63b7e on akretion:8-file-loc into 1cb729d on OCA:8.0.

coveralls · 2016-06-02T10:18:31Z

Coverage increased (+1.3%) to 59.387% when pulling b16fd8f on akretion:8-file-loc into 2e201c2 on OCA:8.0.

coveralls · 2016-06-02T14:13:49Z

Coverage increased (+1.3%) to 59.387% when pulling 9767514 on akretion:8-file-loc into 2e201c2 on OCA:8.0.

coveralls · 2016-06-03T08:16:06Z

Coverage increased (+1.3%) to 59.387% when pulling 9890697 on akretion:8-file-loc into 2e201c2 on OCA:8.0.

coveralls · 2016-06-03T09:15:29Z

Coverage increased (+1.3%) to 59.387% when pulling 1a57029 on akretion:8-file-loc into 2e201c2 on OCA:8.0.

lmignon · 2016-06-03T09:28:32Z

@bealdav The same features are provided by OCA/connector-interfaces#17
This PR is the result of OCA/connector-interfaces#5

bealdav · 2016-06-03T12:01:19Z

The complete story is here: initOS/connector-interfaces#1
This module is an evolution of file exchange to be compatible with connector interfaces.

lmignon · 2016-06-03T12:37:01Z

what about OCA/connector-interfaces#17 ?

sebastienbeau · 2016-06-03T12:58:01Z

Hi @lmignon
In fact, this module do not have the same behaviour. This module is just a piece of the connector flow tool. We modify our work to be compatible with this PR.
If you look here

Add file import/export initOS/connector-interfaces#1
8.0 connector flow connector-interfaces#17 (comment)
Still waiting for some feedback

The aim is to split the feature in small part

having a tool to exchange File (this PR)
having an ETL that use this module : connector-flow
having extra tool (amazon connector, ebay, bank statement...) that use also the exchange of file

bealdav · 2016-06-03T13:05:37Z

@lmignon I think it's important than features are extracted in small modules, don't you think ? tests, and migration easier, more reusable.

lmignon · 2016-06-03T13:13:51Z

@lmignon I think it's important than features are extracted in small modules, don't you think ? tests, and migration easier, more reusable.

@bealdav For sure 😏

@sebastienbeau Thank you for the explanation.

On a first read the code looks really good! I need to find times to review it a little deeper.

lasley · 2016-07-19T16:52:59Z

+        self.env = env
+        self.host = config.get('host', '')
+        self.user = config.get('user', '')
+        self.pwd = config.get('pwd', '')


Is it possible to allow key auth as well?

github-actions · 2021-12-12T12:26:21Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Syncing from upstream OCA/server-tools (10.0)

This was referenced Feb 25, 2016

Add file import/export initOS/connector-interfaces#1

Open

8 module attachment metadata #376

Merged

bealdav force-pushed the 8-file-loc branch 2 times, most recently from 90b4b18 to cfa6a4f Compare February 26, 2016 12:36

This was referenced Apr 7, 2016

Example of the file: delivery_reply akretion/logistics-center#3

Closed

Migration to v8 akretion/logistics-center#4

Closed

moylop260 reviewed May 26, 2016
View reviewed changes

mourad-ehm force-pushed the 8-file-loc branch from 54a828c to ac63b7e Compare May 31, 2016 14:26

mourad-ehm force-pushed the 8-file-loc branch from ac63b7e to b16fd8f Compare June 2, 2016 09:37

Valentin Chemiere and others added 11 commits June 3, 2016 09:33

Add file import/export

b95fb37

POC external_file_location integration in connector_flow

2e47b90

[FIX] encode to utf8 user/password

136a29d

[FIX] prevent not installed class been evaluated

4075ae2

[FIX] python header in akretion modules

85ff3cc

[FIX] check if class is in installed module, README

4247a7f

[FIX] travis for dependency on a PR

c9a0449

[WIP] Use pattern in file name & add move and rename file option

6ea558f

[WIP] use jinja to render new file name based on simple template

3a453b5

[FIX] bug move and rename file option

fcd3cff

[ADD] add file type on task

763c8db

mourad-ehm added 12 commits June 3, 2016 09:33

[FIX] api.multi in task run method

db6dfd0

[FIX] OCA guidelines

c7668b9

[FIX] add authors and contributors

20fee96

[FIX] fix pylint

4d9c30d

[FIX] add oca_dependencies & fixe oca version format

489fe45

[FIX] fix pylint & oca_dependencies

6c29cec

[FIX] python fs lib to travis

58ba998

[FIX] fix views path

ef7c158

[FIX] set application to False

0bea727

[FIX] Move fs lib from travis.yml to requirements.txt

d88b06a

[FIX] delete akretion branch from travis.yml

f99e8c6

[FIX] Remove dependency to Akretion repository in oca_dependencies.txt

9890697

mourad-ehm force-pushed the 8-file-loc branch from 9767514 to 9890697 Compare June 3, 2016 07:36

[FIX] fs lib name

54a4a4f

mourad-ehm force-pushed the 8-file-loc branch from ef9eb39 to 54a4a4f Compare June 3, 2016 08:34

[FIX] fs lib name

1a57029

bealdav mentioned this pull request Jun 13, 2016

Modules to handle files, decisions on their inclusion OCA/connector-interfaces#5

Closed

lasley reviewed Jul 19, 2016
View reviewed changes

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 12, 2021

bealdav closed this Dec 13, 2021

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#377 from OCA/10.0

2889175

Syncing from upstream OCA/server-tools (10.0)

Uh oh!

Conversation

bealdav commented Feb 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moylop260 May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented May 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jun 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmignon commented Jun 3, 2016

Uh oh!

bealdav commented Jun 3, 2016

Uh oh!

lmignon commented Jun 3, 2016

Uh oh!

sebastienbeau commented Jun 3, 2016

Uh oh!

bealdav commented Jun 3, 2016

Uh oh!

lmignon commented Jun 3, 2016

Uh oh!

lasley Jul 19, 2016

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bealdav commented Feb 25, 2016 •

edited

Loading

coveralls commented May 26, 2016 •

edited

Loading

moylop260 May 26, 2016 •

edited

Loading

coveralls commented May 31, 2016 •

edited

Loading

coveralls commented May 31, 2016 •

edited

Loading

coveralls commented Jun 2, 2016 •

edited

Loading

coveralls commented Jun 2, 2016 •

edited

Loading

coveralls commented Jun 3, 2016 •

edited

Loading

coveralls commented Jun 3, 2016 •

edited

Loading