[18.0][IMP] fs_storage: add _move_file helper#606
Open
ArnauCForgeFlow wants to merge 1 commit into
Open
Conversation
Contributor
|
Build fixed here #603 |
2 tasks
ArnauCForgeFlow
force-pushed
the
18.0-imp-fs_storage-add_move_file_method
branch
from
480bdca to
5e87199
Compare
Author
|
Rebased @simahawk |
simahawk
requested changes
May 20, 2026
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
would be nice to have some test cov
ArnauCForgeFlow
force-pushed
the
18.0-imp-fs_storage-add_move_file_method
branch
from
5e87199 to
4726811
Compare
Author
|
@simahawk added tests |
simahawk
approved these changes
May 21, 2026
Author
|
can we merge? @simahawk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a generic
_move_filehelper onfs.storage: checks that the source file exists and schedulesfs.moveas a post-commit hook so the storage stays in sync with the DB transaction.