Fix: Handle null propagation for nullable navigation properties when expanding and ordering#1565
Open
MartinTopfstedtSinc wants to merge 1 commit into
Conversation
…erBy od sub properties
Author
|
@microsoft-github-policy-service agree company="SINC" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes null propagation handling when expanding nullable navigation properties and ordering by their nullable properties.
Changes
IsNullableNavigationProperty()extension method toIEdmPropertyto properly identify nullable navigation propertiesQueryBinder.CreatePropertyAccessExpression()to include nullable navigation properties in null propagation checksHandleNullPropagationis enabled, both nullable value types AND nullable navigation properties are properly handled during query bindingWhy this matters
Previously, when expanding a nullable navigation property and then ordering by an integer property of that same nullable navigation property, the null propagation logic would not correctly handle the nullable navigation property case, potentially causing runtime errors or incorrect query results.
The updated logic now checks for either:
ExpressionBinderHelper.IsNullable(source.Type))property.IsNullableNavigationProperty())This ensures consistent null handling across both scenarios.