Compute all pending ensemble contour maps in one sweep over realizations - #14408
Draft
magnesj wants to merge 3 commits into
Draft
Compute all pending ensemble contour maps in one sweep over realizations#14408magnesj wants to merge 3 commits into
magnesj wants to merge 3 commits into
Conversation
…ding contour map grid
…rect sample count in overlay info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several ensemble contour maps are pending computation, they are now computed in a single sweep over the ensemble realizations, so that each realization case is opened once instead of once per contour map.
ensureResultsComputed()collects the pending sibling maps with views and passes them to the newcomputeStatisticsForMaps(), which merges the previous shared-grid and individual-grid code paths.Additional fixes discovered while testing:
initAfterRead()has run, and then the result definition has no case to resolve the result address against, producing empty results. The result definition case is now initialized before computation.Fixes #14319