#14362 Allow arbitrary Z-scale factor - #14412
Open
magnesj wants to merge 5 commits into
Open
Conversation
Make the Z-scale combo boxes in the toolbar and property editor editable, so any positive scale value can be entered as text. Invalid input is rejected and the previous value is restored. Add keyboard shortcuts Ctrl+Shift+Up and Ctrl+Shift+Down to step the Z-scale of the active view through the predefined scale values.
RimEclipseView::defineEditorAttribute did not call the base class implementation, so the editable Z-scale combo box attribute defined in Rim3dView was never applied for Eclipse views.
Make Rim3dView::isScaleZEditable virtual and const, and return false for contour map views. Replace the dynamic_cast checks on RimEclipseContourMapView in RiuMainWindow and RicZScaleFeatures with the virtual function. Make viewsUsingThisAsComparisonView const to support this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14362
Summary
Rim3dView::isScaleZEditablevirtual and const, overridden inRimEclipseContourMapViewto return false, replacing dynamic_cast checks.