Skip to content

Added API to PluginKit so plugins can trigger hardware detection.#404

Open
godbyk wants to merge 1 commit into
masterfrom
plugin-trigger-hardware-detect
Open

Added API to PluginKit so plugins can trigger hardware detection.#404
godbyk wants to merge 1 commit into
masterfrom
plugin-trigger-hardware-detect

Conversation

@godbyk

@godbyk godbyk commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

This PR addresses issue #155.

@rpavlik

rpavlik commented Sep 23, 2016

Copy link
Copy Markdown
Member

Also needs rebasing by now (sorry) and possibly analysis/commenting of thread safety - may need lock guard in case it's called from an async plugin, etc.

@godbyk godbyk force-pushed the plugin-trigger-hardware-detect branch from 2e4328a to 84b3a12 Compare September 23, 2016 17:12
@godbyk

godbyk commented Sep 23, 2016

Copy link
Copy Markdown
Contributor Author

I rebranched from master and applied this PR patch again so it should merge cleanly now.

As for thread safety, I think we're okay there because we just set a trigger-hardware-detect flag to true (in ServerImpl) and the triggering is actually executed the next time the server loops through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants