fix: add optional card property to Card type - #3348
Open
abhijit9040 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the Joker card label to the Card type, resolving issue #2823 and the svelte-check type error.
Changes:
- Added optional
card?: stringproperty toCard.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a type mismatch issue that was causing
svelte-checkerrors during static analysis, specifically related to the rendering of Joker cards in thecardPreview.sveltecomponent.The YAML data correctly populates the
cardproperty at runtime for Joker cards, but the TypeScriptCardtype definition was missing this property.Changes Made
card?: stringto theCardtype defined insrc/domain/card/card.ts.Verification
pnpm run check(runningsvelte-check) now executes successfully without theProperty 'card' does not exist on type 'Card'error.issue -#2823