fix: show actionable SSL certificate error message for corporate proxy failures#396
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behind a corporate SSL inspection proxy, OSV network calls fail with a raw Node.js error (
self-signed certificate in certificate chain) that gives the user no guidance on what to do.This PR catches SSL certificate errors and replaces the raw message with clear, actionable steps:
Changes:
isSslCertificateError()tosrc/utils/network.tscovering all common Node.js TLS error codes (SELF_SIGNED_CERT_IN_CHAIN,CERT_UNTRUSTED,UNABLE_TO_VERIFY_LEAF_SIGNATURE,DEPTH_ZERO_SELF_SIGNED_CERT,CERT_HAS_EXPIRED)main().catchinsrc/index.tsto check for SSL errors first and show the targeted message before falling through to the generic blocked-network hintCloses #394