Closed
Conversation
added 5 commits
March 31, 2026 19:29
… and ignoredsubnets - Create common::network::dhcpd class wrapping upstream dhcp module - Add custom data types: Eit_types::Network::Dhcp::Pool, Host, Ignoredsubnet - Add iclab.yaml Hiera data with pool and 13 static host reservations - Add ICLAB hierarchy level to common hiera.yaml - Add conditional containment in common::network for dhcpd
Pool options must be Array[String] or String, not Hash. Moved gateway, domain_name, nameservers to proper params.
…bnet types Change Hash-based params to single Optional typed params: - pools -> pool (Optional[Eit_types::Network::Dhcp::Pool]) - hosts -> host (Optional[Eit_types::Network::Dhcp::Host]) - ignoredsubnets -> ignoredsubnet (Optional[Eit_types::Network::Dhcp::Ignoredsubnet]) Update iclab.yaml to use new single-value params.
…gnoredsubnet types" This reverts commit 0e4b3c2.
Update Pool, Host, and Ignoredsubnet types to include Hash wrapper so class params can use the types directly without redundant Hash[] wrapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.