Merged
Conversation
… test Use errors.Is instead of string comparison to properly detect context.Canceled through wrapped error chains. Also handle nil error case to prevent panic on err.Error() call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
KaloyanTanev
approved these changes
Apr 6, 2026
pinebit
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4451 +/- ##
==========================================
+ Coverage 56.55% 56.60% +0.05%
==========================================
Files 245 245
Lines 32826 32826
==========================================
+ Hits 18565 18582 +17
+ Misses 11898 11888 -10
+ Partials 2363 2356 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strings.Contains(err.Error(), context.Canceled.Error())witherrors.Is(err, context.Canceled)to properly detect context cancellation through wrapped error chainsdkg.Runreturns nilcategory: bug
ticket: none