Skip to content

Update address filter hashing to match provider spec - NIT-4754#183

Merged
joshuacolvin0 merged 1 commit intomasterfrom
update-nitro-test-node-for-new-hashing-for-addressfilter
Apr 4, 2026
Merged

Update address filter hashing to match provider spec - NIT-4754#183
joshuacolvin0 merged 1 commit intomasterfrom
update-nitro-test-node-for-new-hashing-for-addressfilter

Conversation

@mahdy-nasr
Copy link
Copy Markdown

Summary

  • Update hashing algorithm in scripts/config.ts to match nitro#4586
  • Salt generation changed from random hex bytes to UUID (crypto.randomUUID())
  • Hash input changed from binary SHA256(salt_bytes + addr_bytes) to string SHA256("{uuid}::0x{address}")
  • Fix MinIO healthcheck in docker-compose.yaml (curlmc ready local)

Testing

  • Verified hash output matches the Go implementation using known test vector (salt: 3ccf0cbf-..., address: 0xddfAbCdc..., expected hash: 0x8fb74f22...)
  • Full E2E test: started testnode with --l2-tx-filtering, added address to filter list, confirmed tx was rejected, removed address, confirmed tx succeeded again

Copy link
Copy Markdown
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge April 4, 2026 22:41
@joshuacolvin0
Copy link
Copy Markdown
Member

@clabot check

@joshuacolvin0
Copy link
Copy Markdown
Member

closing and re-opening to trigger cla-bot

auto-merge was automatically disabled April 4, 2026 22:53

Pull request was closed

@joshuacolvin0 joshuacolvin0 reopened this Apr 4, 2026
@joshuacolvin0 joshuacolvin0 merged commit ab47f95 into master Apr 4, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants