Open
Conversation
Contributor
❌ 15 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
force-pushed
the
braga/consensus-exec-diff-proc
branch
from
be02672 to
b2f5213
Compare
bragaigor
commented
Feb 18, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4386 +/- ##
==========================================
- Coverage 34.42% 33.99% -0.43%
==========================================
Files 494 494
Lines 58930 58966 +36
==========================================
- Hits 20285 20044 -241
- Misses 35054 35370 +316
+ Partials 3591 3552 -39 |
Conversily enable consensus only mode in nitro Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
bragaigor
force-pushed
the
braga/consensus-exec-diff-proc
branch
from
e7dacb1 to
da045ab
Compare
bragaigor
commented
Mar 5, 2026
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables running Nitro in “execution-only” or “consensus-only” mode (splitting normally co-located components) and adds configuration/validation to support RPC-based separation.
Changes:
- Add execution/consensus enablement gating in
cmd/nitro/nitro.goto allow running only one component in-process. - Tighten config validation for RPC-mode requirements and add
--chain.genesis-block-num. - Bump
nitro-testnodesubmodule and document the change in the changelog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| nitro-testnode | Updates testnode submodule revision to pick up supporting changes. |
| execution_consensus/init.go | Allows consensus node to be absent (nil) when starting/stopping nodes. |
| cmd/nitro/nitro.go | Introduces execution/consensus-only gating; adjusts initialization paths accordingly. |
| cmd/nitro/config/config.go | Adds RPC-mode validation rules for mutually exclusive execution vs consensus. |
| cmd/conf/chain.go | Adds genesis-block-num field/flag to L2 chain config. |
| changelog/bragaigor-nit-4241.md | Documents the new mode(s) and new chain config flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
pmikolajczyk41
previously approved these changes
Mar 13, 2026
Member
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
couldn't spot any obvious problems
| } | ||
|
|
||
| if execNode != nil { | ||
| if executionNodeEnabled && execNode != nil { |
Member
There was a problem hiding this comment.
shouldn't/aren't these two checks redundant?
Contributor
Author
There was a problem hiding this comment.
who are we if we don't have redundancy xD jokes apart you're right, I'll remove executionNodeEnabled
diegoximenes
requested changes
Mar 20, 2026
Contributor
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
Not to do in this PR.
But at some point we can have less code blocks gated by if executionNode { for example, and have a single one.
This is decreasing code readability a lot.
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Contributor
Author
agreed and created ticket for it |
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
diegoximenes
requested changes
Mar 31, 2026
| consensusNodeEnabled = nodeConfig.Node.RPCServer.Enable | ||
| } else { | ||
| // same process: no RPC communication | ||
| // TODO: There should be a validation that in this scenario no RPC URL is set. |
| if consensusNodeEnabled { | ||
| var chainConfig *params.ChainConfig | ||
| // TODO: First try to get chainConfig from consensusParsedInitMsg (needs https://github.com/OffchainLabs/nitro/pull/4395) | ||
| chainConfig, err = chaininfo.GetChainConfig(new(big.Int).SetUint64(nodeConfig.Chain.ID), nodeConfig.Chain.Name, nil, nodeConfig.Chain.InfoFiles, nodeConfig.Chain.InfoJson) |
Contributor
There was a problem hiding this comment.
There is this code block before:
chainInfo, err := chaininfo.ProcessChainInfo(nodeConfig.Chain.ID, nodeConfig.Chain.Name, nodeConfig.Chain.InfoFiles, nodeConfig.Chain.InfoJson)
if err != nil {
log.Error("error processing l2 chain info", "err", err)
return 1
}
This chainInfo is only retrieved in order to read the inner chain config.
Change this code block to use chaininfo.GetChainConfig, and remove this chaininfo.GetChainConfig from inside this if.
Contributor
Author
There was a problem hiding this comment.
Was able to remove chaininfo.GetChainConfig(..) completely in favour of using chainInfo.ChainConfig in a8b6a6b
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable execution only mode in nitro as well as consensus only mode
closes NIT-4241
relates to NIT-4202
pulls in OffchainLabs/nitro-testnode#177