Test PR- Fix keyboard focus in location dropdown for accessibility#645
Open
aanchalbhansali wants to merge 1 commit intomasterfrom
Open
Test PR- Fix keyboard focus in location dropdown for accessibility#645aanchalbhansali wants to merge 1 commit intomasterfrom
aanchalbhansali wants to merge 1 commit intomasterfrom
Conversation
When the location dropdown is expanded via keyboard (Tab + Enter), focus now automatically moves to the currently selected section item within the dropdown, improving keyboard navigation and meeting accessibility standards (Focus Order - MS Liquid guidelines). Changes: - Added focusOnSelectedSection() method to set focus on the selected section when the dropdown opens - Method tries to find the selected element by: 1. Section ID (curSectionId) 2. aria-selected="true" attribute 3. First .Section element as fallback - Integrated into onPopupToggle callback with setTimeout to ensure the popup has rendered before setting focus Fixes #622 Co-authored-by: Aanchal Bhansali <aanchalbhansali@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #622
Summary
When the location dropdown is expanded via keyboard (Tab + Enter), focus now automatically moves to the currently selected section item within the dropdown, improving keyboard navigation and meeting accessibility standards.
Changes
focusOnSelectedSection()method to set focus on the selected section when the dropdown opensTesting
Manual testing recommended:
Complies with Microsoft Liquid accessibility guidelines for Focus Order (02.04.03).
Generated with Claude Code