Support new JWT token based auth (openEO API 1.3.0)#859
Support new JWT token based auth (openEO API 1.3.0)#859niebl wants to merge 49 commits intoOpen-EO:masterfrom
Conversation
|
still WIP, as testing with JWT conformant backends is not yet implemented (manual tests have shown that there is still something going wrong though) |
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
Co-authored-by: Matthias Mohr <m.mohr@moregeo.it>
|
hmm, it seems this PR got in a bad state, making the signal/noise ratio bad for review. I see various changes in places that are unrelated to the feature to implement here (conversions.py, results.py, _version.py, metadata.py, test_s3sts.py, ...) did you by any chance cherry-picked commits from master, instead of merging master? |
soxofaan
left a comment
There was a problem hiding this comment.
sorry for delay, I finally found some time to give this another review
|
and another thing: this deserves a mention in the changelog too |
9e341cc to
8ed91bf
Compare
|
Thank you very much for the review. I am sorry for the delay. I will be able to work on that feedback now |
|
@soxofaan thank you for the review. I was able to apply your suggestions and shrink the size of the PR a little. I am once again sorry for the delay |
#850
Includes:
connection.authenticate_basic()andconnection.authenticate_oidc()and formatting the bearer tokens accordingly/conformanceendpoint inDummyBackendand ahas_conformance({url})method in capabilities. So JWT bearer token conformance can be checked.