fix(config): deep-compare arrays in config diff to eliminate reload false-positives

[Gucc111]

Summary

• Fix diffValues in classifyChanges.ts to recursively compare arrays element-by-element instead of using Object.is() reference equality. This eliminates false-positive config change detection that caused unnecessary runtime invalidation and always-on restart cycles.
• Add 15 unit tests covering array deep comparison, issue Config reload false-positive causes runtime invalidation and always-on restart #147 scenario reproduction, object diff regression, and edge cases.

Closes #147

Root Cause

diffValues used isDiffableObject() which explicitly excludes arrays (!Array.isArray(value)), causing arrays to fall through to the Object.is() leaf comparison. Since every loadPilotConfig() call creates new array instances via [...DEFAULT_*] / .map() / .filter(), identical arrays with different references were always reported as changed.

The 6 affected fields — alwaysOn.dormancy.ignoreGlobs, model.providers.*.models.*.multimodal.input, router.autoOrchestrate.allowedTools, router.autoOrchestrate.triggerTiers, router.fallback.default, router.tokenSaver.rules — are all array-typed config values that get freshly allocated on each parse.

Test plan

• 15 new unit tests all pass (node --test)
• Start PilotDeck, click "Reload Current" in Settings without modifying config — no Config reloaded, invalidating runtimes log should appear
• Send a chat message — no spurious config reload log on turn start
• Edit a scalar field in pilotdeck.yaml (e.g. alwaysOn.dormancy.debounceMs) — only that field is reported, no array fields leak into the diff

Made with Cursor