Add preference to disable automatic pen/eraser switching#1487
Add preference to disable automatic pen/eraser switching#1487SofianElmotiem wants to merge 2 commits into
Conversation
|
In my opinion, this seems to be a workaround for broken pens. As such, I'd rather the option make that clear with a text like "Ignore broken eraser detection for tablets", defaulting to off. Similar for the variables. The proper solution would be a driver fix for the pen to disable this behaviour globally, since other software would behave just like OpenBoard. This is far outside the remit of OpenBoard. |
|
Thanks for the review! Makes sens |
|
Looks fine now. The commit messages are very structured. |
|
Your suggestion made the intent much clearer that i need to rethink about it , and let me know if there is anything else to adjust before this can be merged. |
|
Some people like to add a What do you think? |
|
Honsetly did not know it before but for sure happy to add it |
711621f to
142b2b4
Compare
|
I saw that your account is quite new, so I thought to mention it. |
|
thats right it took me some time considering contributing to opensource but i did it in the end. so i am happy to share and learn from the community. |
|
Welcome to opensource! |
Fixes the annoyance where Openboard auto-switches to the eraser tool when a tablet device (like the Promethean Activ Panel) detects the eraser pointer type. There is now a checkbox in the Pen preferences tab to turn this off. Defaults to on so nothing changes for existing users. Closes OpenBoard-org#1432
Rename boardAutoSwitchToEraser -> boardIgnoreBrokenEraserDetection to make it clear this is a workaround for broken eraser detection, not a general preference. Default is now false (opt-in). Update the checkbox label to "Ignore broken eraser detection for tablets". Signed-off-by: SofianElmotiem <sofianelmotiem@gmail.com>
142b2b4 to
6dd8554
Compare
Fixes the annoyance where Openboard auto-switches to the eraser tool when a tablet device (like the Promethean Activ Panel) detects the eraser pointer type. There is now a checkbox in the Pen preferences tab to turn this off. Defaults to on so nothing changes for existing users.
Closes #1432