Bump Fluidd to v1.37.1#199
Open
pdscomp wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Yocto recipe for Fluidd to v1.37.1 and adjusts the OpenCentauri theme patcher to keep working across upstream minified bundle changes.
Changes:
- Updated Fluidd recipe
SRC_URI[sha256sum]andLIC_FILES_CHKSUMfor the v1.37.1 release zip contents. - Switched the theme patcher’s
onThemeChangeinjection from hardcoded minified identifiers to a regex-based match and substitution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| meta-opencentauri/recipes-apps/fluidd/fluidd_1.37.1.bb | Updates source and license checksums for the v1.37.1 Fluidd release artifact. |
| meta-opencentauri/recipes-apps/fluidd/files/opencentauri-fluidd-theme/apply-opencentauri-fluidd-theme.py | Makes the JS bundle patching more resilient by matching onThemeChange via regex before injecting dataset toggling logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| f'n.dark=t.isDark,n.currentTheme.primary=t.color,' | ||
| f'n.currentTheme[`primary-offset`]=new {color_class}(t.color).desaturate(5).darken(10).toHexString(),' | ||
| f'n.themes.dark.logo=t.logo.light,n.themes.light.logo=t.logo.dark;' | ||
| f'document.documentElement.dataset.fluiddTheme=(t.logo?.src===`logo_opencentauri.svg`)?`OpenCentauri`:``}}' |
Comment on lines
+152
to
+164
| match = on_theme_re.search(text) | ||
| if not match: | ||
| raise RuntimeError(f"{path}: onThemeChange pattern not found") | ||
| theme_var, color_class = match.groups() | ||
| old_on_theme_change = match.group(0) | ||
| new_on_theme_change = ( | ||
| f'async onThemeChange(e,t){{let n={theme_var}.framework.theme;' | ||
| f'n.dark=t.isDark,n.currentTheme.primary=t.color,' | ||
| f'n.currentTheme[`primary-offset`]=new {color_class}(t.color).desaturate(5).darken(10).toHexString(),' | ||
| f'n.themes.dark.logo=t.logo.light,n.themes.light.logo=t.logo.dark;' | ||
| f'document.documentElement.dataset.fluiddTheme=(t.logo?.src===`logo_opencentauri.svg`)?`OpenCentauri`:``}}' | ||
| ) | ||
| text = text.replace(old_on_theme_change, new_on_theme_change, 1) |
Changes: - Rename recipe: fluidd_1.37.0.bb -> fluidd_1.37.1.bb - Update SRC_URI sha256sum for v1.37.1 release zip f08e9d438fdce472553e1ce46a9be62f5ababb4b0f64f65efbd4561d9379653c - Update LIC_FILES_CHKSUM for new index.html md5=3b00ecfc948a3467a588bf3a3eb33a00 - Fix theme patcher to use regex for onThemeChange The minified variable names (Io->tJ, ft->OJ) change between builds. Use a regex that captures the variable names dynamically so the patch works across both v1.37.0 and v1.37.1 (and future builds).
✅ Build ArtifactsBranch:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Fluidd web UI package to the latest v1.37.1 release.
Changes
fluidd_1.37.0.bb→fluidd_1.37.1.bbf08e9d438fdce472553e1ce46a9be62f5ababb4b0f64f65efbd4561d9379653cmd5=3b00ecfc948a3467a588bf3a3eb33a00for the newindex.htmlonThemeChangeJavaScript patch to use regex instead of hardcoded minified variable names (Io→tJ,ft→OJin v1.37.1). The patcher now dynamically captures the minified variable names so it works across both v1.37.0 and v1.37.1.Verification
LIC_FILES_CHKSUMfrom v1.37.1index.htmlpython3 -m py_compilepasses forapply-opencentauri-fluidd-theme.pyindex.html,manifest.webmanifest,onThemeChange, and favicon output in extracted bundlesUpstream release notes: https://github.com/fluidd-core/fluidd/releases/tag/v1.37.1