Open
Conversation
Two new endpoints on the internal API: - POST /info/users/nameid — forward lookup (sho + uid + sp_entityid → nameid) - POST /info/users/id — reverse lookup (nameid → sho + uid + sp_entityid) Both require ROLE_API_USER_NAMEID_LOOKUP and are feature-flag gated.
kayjoosten
force-pushed
the
feature/1931-nameid-lookup-api
branch
from
71be884 to
2ed58fd
Compare
kayjoosten
changed the title
kayjoosten
force-pushed
the
feature/1931-nameid-lookup-api
branch
from
2ed58fd to
6367c74
Compare
johanib
requested changes
Apr 8, 2026
kayjoosten
force-pushed
the
feature/1931-nameid-lookup-api
branch
from
9b34a40 to
c074c69
Compare
… flag api.users_nameid_lookup
kayjoosten
force-pushed
the
feature/1931-nameid-lookup-api
branch
from
d049fad to
c16155e
Compare
johanib
reviewed
Apr 15, 2026
| return new NameIdResult($stored->persistentId, true); | ||
| } | ||
|
|
||
| return new NameIdResult(SamlPersistentId::generate($userUuid, $spUuid)->persistentId, false); |
| private function insertUserFixture(string $userUuid): void | ||
| { | ||
| $collabId = 'urn:collab:person:' . self::SHO . ':' . self::UID; | ||
| $this->connection()->executeStatement( |
Contributor
There was a problem hiding this comment.
I'm triggered by the use of fixture methods inside the tests.
this is not reusable, and can get messy in the long run.
But, afaiks, there is no pre existing pattern that does it differently. And as long as the delete queries do not cause issues with other tests (which would indicate issues/tech dept at other places), this should not be a problem.
So, good enough to do it like this for now.
| api.users.deprovision.username: lifecycle | ||
| api.users.deprovision.password: secret | ||
| api.users.nameIdLookup.username: nameid | ||
| api.users.nameIdLookup.password: secret |
Contributor
There was a problem hiding this comment.
Every other parameter name is in lowercase. Probably better to remain consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.