Revert feature flag to enable/disable content hash cleanup#1966
Revert feature flag to enable/disable content hash cleanup#1966
Conversation
The `feature_stable_consent_hash_migration` feature flag was confusing, and setting the old hash to null provided no real value
01dd4be to
882403b
Compare
kayjoosten
left a comment
There was a problem hiding this comment.
I miss the migration where we make the consent hash nullable that is not needed anymore after this change right?
With this change, we no longer generate the old hashes? New hashes are always the stable hashes. So new users insert null into the old hash column? |
|
Discussed with Kay: We can remove the dropping of the not null from the current migration. If this were to be a new migration, we would not, as it does not really matter. But removing it prevents a unneeded operation on the prod db. |
Good catch! 👍 Updated the migration (🙈 ) |
1e69e72 to
896af3d
Compare
The
feature_stable_consent_hash_migrationfeature flag was confusing, and setting the old hash to null provided no real value