Skip to content

Revert feature flag to enable/disable content hash cleanup#1966

Open
johanib wants to merge 2 commits intomainfrom
feature/cleanup-feature-flag
Open

Revert feature flag to enable/disable content hash cleanup#1966
johanib wants to merge 2 commits intomainfrom
feature/cleanup-feature-flag

Conversation

@johanib
Copy link
Copy Markdown
Contributor

@johanib johanib commented Apr 8, 2026

The feature_stable_consent_hash_migration feature flag was confusing, and setting the old hash to null provided no real value

@johanib johanib requested a review from kayjoosten April 8, 2026 13:24
The `feature_stable_consent_hash_migration` feature flag was confusing, and setting the old hash to null provided no real value
@johanib johanib force-pushed the feature/cleanup-feature-flag branch from 01dd4be to 882403b Compare April 8, 2026 13:46
Copy link
Copy Markdown
Contributor

@kayjoosten kayjoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the migration where we make the consent hash nullable that is not needed anymore after this change right?

@johanib
Copy link
Copy Markdown
Contributor Author

johanib commented Apr 9, 2026

I miss the migration where we make the consent hash nullable that is not needed anymore after this change right

With this change, we no longer generate the old hashes? New hashes are always the stable hashes. So new users insert null into the old hash column?

@johanib johanib requested a review from kayjoosten April 9, 2026 11:34
@github-project-automation github-project-automation bot moved this from New to Backlog in PHP development Apr 14, 2026
@johanib johanib moved this from Backlog to In Progress in PHP development Apr 14, 2026
@johanib
Copy link
Copy Markdown
Contributor Author

johanib commented Apr 14, 2026

Discussed with Kay: We can remove the dropping of the not null from the current migration. If this were to be a new migration, we would not, as it does not really matter. But removing it prevents a unneeded operation on the prod db.

@johanib
Copy link
Copy Markdown
Contributor Author

johanib commented Apr 14, 2026

I miss the migration where we make the consent hash nullable that is not needed anymore after this change right?

Good catch! 👍 Updated the migration (🙈 )

@johanib johanib force-pushed the feature/cleanup-feature-flag branch from 1e69e72 to 896af3d Compare April 14, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants