Make reactive form editing progressive and typed - #3
Merged
Conversation
|
👀 Human Input Needed → Pair Review Briefing |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| resolved_type = resolve_optional(request.param_type) | ||
| resolved_type = request.param_type | ||
| while resolved_type not in self.direct_factories: | ||
| owned_type = resolve_annotated(resolved_type) |
There was a problem hiding this comment.
Resolving Annotated wrappers here lets annotated Path declarations use EnhancedPathWidget, but the value-conversion path still receives the original annotation. Since convert_widget_value_to_type only converts when param_type is Path, EnhancedPathWidget.get_value() emits a str that is either stored as the wrong type or rejected for Path | None, so edited annotated path fields regress.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
trissim
force-pushed
the
agent/typed-graph-colors-shortcuts
branch
from
July 30, 2026 21:45
2a7880c to
f827058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies placeholder and enabled-state chrome as form batches materialize, makes authoritative resets discard invalid transient editor text, preserves annotated widget declarations, adds a dedicated key-sequence editor, replaces free-form performance graph colors with a finite enum, and supports plate-scoped functions with no image backend.\n\nDepends on python-introspect 0.1.8.\n\nVerification: 264 tests passed; wheel and sdist pass twine check.