Add inherited dataclass annotation validation - #1
Merged
Conversation
trissim
marked this pull request as ready for review
July 30, 2026 17:30
|
👀 Human Input Needed → Pair Review Briefing |
| the same bases. | ||
| """ | ||
|
|
||
| def __post_init__(self) -> None: |
There was a problem hiding this comment.
This inherited hook is incompatible with dataclasses that declare InitVar fields because dataclasses pass each InitVar value into __post_init__; with this zero-argument signature those classes fail during construction before validation runs. That makes the mixin unusable for a supported dataclass feature even though it is intended as a generic lifecycle hook.
Severity: medium
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AnnotatedDataclassValidationMixinWhy
Annotated Python types are the runtime schema. Dataclass declarations need one generic lifecycle hook instead of repeating per-field or per-package validation code.
Validation
99 passed