Release v1.23.1#179
Open
neubig wants to merge 1 commit into
Open
Conversation
all-hands-bot
approved these changes
May 24, 2026
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean, simple addition of observability user ID support.
The implementation correctly threads userId through the conversation creation flow, following the existing pattern for optional configuration (e.g., hookConfig). The fallback logic (options.userId ?? this.userId ?? undefined) is consistent and well-tested.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW - Additive change only (optional field)
- Well-tested with unit tests covering both regular and ACP conversation creation
- No breaking changes or security implications
- Aligns with server API v1.23.1
VERDICT:
✅ Worth merging: Solid implementation, ready to ship.
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/typescript-client/actions/runs/26359090536
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.23.1
This PR prepares the TypeScript client for the OpenHands Software Agent SDK / agent-server v1.23.1 release.
Included client update
user_idto conversation creation request types.userIdoptions throughRemoteConversation.start,RemoteConversationOptions, andConversationManagerhelpers.Release note
After this PR merges, create/push tag
v1.23.1onmainto trigger the TypeScript clientReleaseworkflow and publish@openhands/typescript-client@1.23.1.Testing
npm testnpm run buildnpm run format:checknpm run lint(existing warnings only)git diff --check