Skip to content

Release v1.23.1#179

Open
neubig wants to merge 1 commit into
mainfrom
codex/release-1.23.1-user-id
Open

Release v1.23.1#179
neubig wants to merge 1 commit into
mainfrom
codex/release-1.23.1-user-id

Conversation

@neubig
Copy link
Copy Markdown
Member

@neubig neubig commented May 24, 2026

Release v1.23.1

This PR prepares the TypeScript client for the OpenHands Software Agent SDK / agent-server v1.23.1 release.

Included client update

  • Add optional user_id to conversation creation request types.
  • Thread ergonomic userId options through RemoteConversation.start, RemoteConversationOptions, and ConversationManager helpers.
  • Add unit coverage for regular and ACP conversation creation payloads.

Release note

After this PR merges, create/push tag v1.23.1 on main to trigger the TypeScript client Release workflow and publish @openhands/typescript-client@1.23.1.

Testing

  • npm test
  • npm run build
  • npm run format:check
  • npm run lint (existing warnings only)
  • git diff --check

@neubig neubig changed the title Add conversation userId request support Release v1.23.1 May 24, 2026
Copy link
Copy Markdown

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean, simple addition of observability user ID support.

The implementation correctly threads userId through the conversation creation flow, following the existing pattern for optional configuration (e.g., hookConfig). The fallback logic (options.userId ?? this.userId ?? undefined) is consistent and well-tested.

[RISK ASSESSMENT]

  • [Overall PR] ⚠️ Risk Assessment: 🟢 LOW
  • Additive change only (optional field)
  • Well-tested with unit tests covering both regular and ACP conversation creation
  • No breaking changes or security implications
  • Aligns with server API v1.23.1

VERDICT:
Worth merging: Solid implementation, ready to ship.


Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/typescript-client/actions/runs/26359090536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants