Allow benchmark targets to link against a user-specified OpenBLAS library#5875
Closed
naoto-aoki-fy wants to merge 1 commit into
Closed
Allow benchmark targets to link against a user-specified OpenBLAS library#5875naoto-aoki-fy wants to merge 1 commit into
naoto-aoki-fy wants to merge 1 commit into
Conversation
- Add OPENBLAS_LIB with the existing library path as the default - Replace direct ../$(LIBNAME) dependencies across benchmark .goto targets
Author
|
I noticed a mistake, so I'll close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the benchmark Makefile support linking benchmark binaries against a configurable OpenBLAS library.
It introduces the
OPENBLAS_LIBvariable, which defaults to the existing../$(LIBNAME)path, and replaces hard-coded references to../$(LIBNAME)in benchmark link targets with this variable.Motivation
The benchmark targets currently depend directly on
../$(LIBNAME), which makes it difficult to link them against OpenBLAS packages provided by Linux distributions or other externally installed OpenBLAS libraries.By making the library path configurable, downstream packagers and users can more easily build benchmark binaries against a distro-provided OpenBLAS package, including shared-library installations. For example, benchmarks can be built with an externally provided library by passing
OPENBLAS_LIBon the make command line:The default behavior is preserved when
OPENBLAS_LIBis not overridden.Changes
OPENBLAS_LIB ?= ../$(LIBNAME)tobenchmark/Makefile../$(LIBNAME)dependencies with$(OPENBLAS_LIB)across.gotobenchmark targetsmake OPENBLAS_LIB=-lopenblasoOPENBLAS_LIBis not overriddenNotes
This change is intended to improve build flexibility for benchmark targets, especially for packaging environments that prefer linking against system-provided OpenBLAS libraries.