fix thread safety and data races of openmp backend#5876
Open
kumaraditya303 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #5844 and #5838 and fixes thread safety issues and data races in openmp implementation backend.
The main important change is that now if C11 is supported the it now uses atomics based locking instead of platform specific assembly code to do the locking which isn't compatible with TSAN nor fully safe, volatile reads/writes are not sufficient to prevent data races. I've also setup CI to test the openmp backend under TSAN and there are several other fixes to use atomics where necessary to fix the remaining data races. After all these fixes there are no data races while running the thread safety tests under TSAN.