Skip to content

Adjustable Note Selection Highlight Intensity option #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OctoFlareDev merged 9 commits into from
Mar 25, 2026
Merged

Adjustable Note Selection Highlight Intensity option #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbbac9d
add selection_alpha in control_create
RaviScriptDev Feb 25, 2026
b6f064e
add selection_alpha to settings saving/loading
RaviScriptDev Feb 25, 2026
9b65908
replace the magic number 0.8 for block alpha when selected with selec…
RaviScriptDev Feb 25, 2026
4dbd6fe
implement adjustable alpha for selection when drawing the selection
RaviScriptDev Feb 26, 2026
14c5fc2
add dragbar to preferences window for selection_alpha
RaviScriptDev Feb 26, 2026
5dc184c
update selection_alpha input type
RaviScriptDev Mar 22, 2026
73a0489
add simplified chinese translation for selection_alpha
RaviScriptDev Mar 22, 2026
1aac035
Merge branch 'development' into feature/adjustable-selection-alpha
RaviScriptDev Mar 22, 2026
2c49ad1
increment the position slightly to the right for simplified chinese part
RaviScriptDev Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/control_create/control_create.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,8 @@ function control_create() {
sound_stopper_set_start = -1
sound_stopper_set_until = -1

selection_alpha = 0.8

// Layers
show_layers = 1
realvolume = 1
Expand Down
4 changes: 2 additions & 2 deletions scripts/control_draw/control_draw.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ function control_draw() {
}
if (fade=0) c += ((selbx = current_song.starta + a && selby = current_song.startb + b && select = 0 && window = 0 && cursmarker = 0) || s) * 0.5
}
draw_block(x1 + 2 + 32 * a - note_offset, y1 + 34 + 32 * b, current_song.song_ins[current_song.starta + a, current_song.startb + b], current_song.song_key[current_song.starta + a, current_song.startb + b], current_song.song_pan[current_song.starta + a, current_song.startb + b], current_song.song_vel[current_song.starta + a, current_song.startb + b], current_song.song_pit[current_song.starta + a, current_song.startb + b], c, s * 0.8)
draw_block(x1 + 2 + 32 * a - note_offset, y1 + 34 + 32 * b, current_song.song_ins[current_song.starta + a, current_song.startb + b], current_song.song_key[current_song.starta + a, current_song.startb + b], current_song.song_pan[current_song.starta + a, current_song.startb + b], current_song.song_vel[current_song.starta + a, current_song.startb + b], current_song.song_pit[current_song.starta + a, current_song.startb + b], c, s * selection_alpha)
if (current_song.instrument_list[| ds_list_find_index(current_song.instrument_list, current_song.song_ins[current_song.starta + a, current_song.startb + b])].name = "Tempo Changer") array_push(tempo_changer_display_queue, [x1 + 2 + 32 * a - note_offset, y1 + 34 + 32 * b, string(abs(current_song.song_pit[current_song.starta + a, current_song.startb + b]))])
}
}
Expand Down Expand Up @@ -375,7 +375,7 @@ function control_draw() {
if (fade=0) c += ((selbx = current_song.starta + a && selby = current_song.startb + b && select = 0 && window = 0 && cursmarker = 0) || s) * 0.5
}
realkey = current_song.song_key[current_song.starta + a, current_song.startb + b] + current_song.song_pit[current_song.starta + a, current_song.startb + b] / 100
draw_block(floor(centerx - (52 * 39) / 2) + floor(19.5 * (realkey + floor(realkey / 12) * 2 + (realkey mod 12 >= 8) + (realkey mod 12 >= 3))) + 4, rh - 154 - a * 32 - 32 + note_offset, current_song.song_ins[current_song.starta + a, current_song.startb + b], current_song.song_key[current_song.starta + a, current_song.startb + b], current_song.song_pan[current_song.starta + a, current_song.startb + b], current_song.song_vel[current_song.starta + a, current_song.startb + b] * (current_song.layervol[b] / 100), current_song.song_pit[current_song.starta + a, current_song.startb + b], c, s * 0.8)
draw_block(floor(centerx - (52 * 39) / 2) + floor(19.5 * (realkey + floor(realkey / 12) * 2 + (realkey mod 12 >= 8) + (realkey mod 12 >= 3))) + 4, rh - 154 - a * 32 - 32 + note_offset, current_song.song_ins[current_song.starta + a, current_song.startb + b], current_song.song_key[current_song.starta + a, current_song.startb + b], current_song.song_pan[current_song.starta + a, current_song.startb + b], current_song.song_vel[current_song.starta + a, current_song.startb + b] * (current_song.layervol[b] / 100), current_song.song_pit[current_song.starta + a, current_song.startb + b], c, s * selection_alpha)
}
}
} else {
Expand Down
6 changes: 6 additions & 0 deletions scripts/draw_window_preferences/draw_window_preferences.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,9 @@ function draw_window_preferences() {
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 210, fade, "No fading", "Disables transparency animations on note block sprites")) fade = !fade
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 230, show_layers, "Show layer boxes", "Whether the layer boxes should be shown\non the left side of the workspace.")) show_layers = !show_layers
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 250, remove_effect, "Show effect on removal", "Whether to show a fading border\nwhen removing a note block.")) remove_effect = !remove_effect
draw_text_dynamic(x1 + 60, y1 + 268 + (theme = 3) * 22, "Selection highlight intensity: %")
selection_alpha = median(10, draw_dragvalue(21, x1 + 218, y1 + 268 + (theme = 3) * 22, selection_alpha * 100, 2), 80) / 100

if (theme = 3) draw_theme_font(font_info_med)
draw_areaheader(x1 + 22, y1 + 294 + (theme = 3) * 22, 456, 171, "Piano")
if (theme = 3) draw_theme_font(font_main)
Expand Down Expand Up @@ -505,6 +508,9 @@ function draw_window_preferences() {
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 210, fade, "音符盒不透明", "关闭音符盒上的透明效果。")) fade = !fade
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 230, show_layers, "显示每层操作区", "显示在界面左侧操作每层设定的区域。")) show_layers = !show_layers
if (draw_checkbox(x1 + 40, y1 + (theme = 3) * 22 + 250, remove_effect, "显示删除效果", "删除音符时显示淡出边框效果。")) remove_effect = !remove_effect
draw_text_dynamic(x1 + 60, y1 + 268 + (theme = 3) * 22, "选择突出显示强度： %")
selection_alpha = median(10, draw_dragvalue(21, x1 + 172, y1 + 268 + (theme = 3) * 22, selection_alpha * 100, 2), 80) / 100

if (theme = 3) draw_theme_font(font_info_med)
draw_areaheader(x1 + 22, y1 + 294 + (theme = 3) * 22, 456, 171, "琴键")
if (theme = 3) draw_theme_font(font_main)
Expand Down
1 change: 1 addition & 0 deletions scripts/load_settings/load_settings.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ function load_settings() {
show_octaves = ini_read_real( "preferences", "show_octaves", show_octaves)
show_incompatible = ini_read_real( "preferences", "show_incompatible", show_incompatible)
fade = ini_read_real( "preferences", "use_fading", fade)
selection_alpha = ini_read_real( "preferences", "selection_alpha", selection_alpha)
show_layers = ini_read_real( "preferences", "show_layers", show_layers)
show_piano = ini_read_real( "preferences", "show_piano", show_piano)
keysmax = ini_read_real( "preferences", "keys_to_show", keysmax)
Expand Down
1 change: 1 addition & 0 deletions scripts/save_settings/save_settings.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ function save_settings() {
ini_write_real_clean("preferences", "show_numbers", show_numbers)
ini_write_real_clean("preferences", "show_octaves", show_octaves)
ini_write_real_clean("preferences", "show_incompatible", show_incompatible)
ini_write_real_clean("preferences", "selection_alpha", selection_alpha)
ini_write_real_clean("preferences", "use_fading", fade)
ini_write_real_clean("preferences", "show_layers", show_layers)
ini_write_real_clean("preferences", "show_piano", show_piano)
Expand Down
8 changes: 4 additions & 4 deletions scripts/selection_draw/selection_draw.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ function selection_draw(argument0, argument1, argument2, argument3) {
sb = b - songs[song].selection_y
if (sb >= songs[song].selection_colfirst[sa] && sb <= songs[song].selection_collast[sa]) {
if (songs[song].selection_exists[sa, sb]) {
salpha = 0.8
salpha = selection_alpha
if (window < 1) {
if (select = 2) {
if (is_inside(a, b, select_pressa, select_pressb, selbx, selby)) salpha = 0.5
if (is_inside(a, b, select_pressa, select_pressb, selbx, selby)) salpha = 0.5 * 0.625
} else if (select = 0 && !cursmarker && playing = 0) {
if (mouse_rectangle(xs + (a - songs[song].starta) * 32, ys + (b - songs[song].startb) * 32, 32, 32)) {
salpha = 0.7
salpha = selection_alpha * (0.8 * (selection_alpha > 0.4) - 0.08 * (selection_alpha > 0.4))
curs = cr_size_all
if (mouse_check_button_pressed(mb_left)) {
window = w_dragselection
Expand All @@ -72,7 +72,7 @@ function selection_draw(argument0, argument1, argument2, argument3) {
}
}
} else if (window = w_dragselection) {
if (select_pressa = sa && select_pressb = sb) salpha = 0.7
salpha = selection_alpha * (0.8 * (selection_alpha > 0.4) - 0.08 * (selection_alpha > 0.4))
}
// salpha += 0.1 * (1 - (min(1000, current_time - selection_played[sa, sb]) / 1000))
draw_block(xs + (a - songs[song].starta) * 32, ys + (b - songs[song].startb) * 32, songs[song].selection_ins[sa, sb], songs[song].selection_key[sa, sb], songs[song].selection_pan[sa, sb], songs[song].selection_vel[sa, sb], songs[song].selection_pit[sa, sb], 1, salpha)
Expand Down