textfilecontent54 probe: fix memory leaks in process_file#2370
Open
edznux-dd wants to merge 1 commit into
Open
textfilecontent54 probe: fix memory leaks in process_file#2370edznux-dd wants to merge 1 commit into
edznux-dd wants to merge 1 commit into
Conversation
Found by fuzzing process_file() under ASan/LSan. - create_item()'s returned object was passed to SEXP_list_add(), which takes its own reference, but the caller's reference was never released -> every collected item leaked. Free our reference after adding. - The items accumulator list itself was never freed on return. Free it at cleanup; collected items are owned by the probe result object, so this only releases the list's references (and frees any uncollected items).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by fuzzing process_file() under ASan/LSan (see harnesses in #2365)