test: POSIX-normalise paths in link_priority_structural_test (fixes 4 Windows-only failures)

[dev-noaman]

Green on CI, red on Windows

link_priority_structural_test.dart collects lib/**.dart with
Directory('lib').listSync(), which returns native path separators. Every assertion
in the file is written POSIX-style, so on Windows 4 of its 5 tests fail:

Expected: a string starting with 'lib/ble/ble_engine.dart:'
  Actual: 'lib\ble\ble_engine.dart:781'

and the helper

List<String> _engine() => _libSources()
    .firstWhere((e) => e.key.endsWith('ble/ble_engine.dart'))
    .value;

throws a bare Bad state: No element — which names neither the file nor the cause,
so the first guess is that something in ble_engine.dart actually broke.

CI runs on Linux, so main is green and this is invisible to the project. It just costs
every Windows contributor the same half hour, on a test that is doing its job correctly.

Same class of thing as #246 — not a bug in the repo's logic, a bug in what the repo
assumes about the machine it is built on.

Fix

Normalise once where the paths are collected, not at each assertion:

out.add(MapEntry(
  entity.path.replaceAll(Platform.pathSeparator, '/'),
  codeLines(entity.readAsStringSync()),
));

Two deliberate choices:

• At collection, not at the assertions. Nothing this file pins is platform-specific,
  so the paths it reasons about shouldn't be either. The five assertions keep reading as
  the single spelling they already use, and a future assertion can't reintroduce the bug
  by forgetting to normalise.
• Platform.pathSeparator, not a literal \. On POSIX this is a no-op, whereas a
  blanket backslash replacement would corrupt a filename that legally contains one.

Verification

• Before: 1 passed, 4 failed (Windows). After: 5 passed.

• The test still bites. I dropped a second requestConnectionPriority call into
  lib/ and confirmed it still fails — a path fix that quietly stopped the check from
  catching anything would be worse than the bug:

  exactly one requestConnectionPriority call, and it is in the engine [E]
    a second request site can bypass the policy.
    Found: [lib/_tmp_violation.dart:4, lib/ble/ble_engine.dart:797]
  

  As a side benefit the diagnostic now reads in one consistent spelling instead of mixing
  separators.

• No behavioural change on Linux/macOS: Platform.pathSeparator is / there, so the
  replacement is identity.

no_debug_only_apis_test.dart uses the same grep approach but asserts no paths, so it is
unaffected — this is the only file with the issue.

[coderabbitai]

Warning

Review limit reached

@dev-noaman, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 511b9f16-3188-4ecf-aaa9-b796dad3f958

📥 Commits

Reviewing files that changed from the base of the PR and between 7c789d7 and d37fafd.

📒 Files selected for processing (1)

• test/link_priority_structural_test.dart

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}