-
Notifications
You must be signed in to change notification settings - Fork 11
surface the echoed request seq on cmd_response #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 2069
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 225
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 401
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 200
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 4134
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 244
🏁 Script executed:
# Look at the entire control.dart file to understand command parsing wc -l lib/src/control.dartRepository: OpenStrap/protocol
Length of output: 181
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 2637
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
# Check if there are any test files that show actual command response formats cat test/hello_test.dartRepository: OpenStrap/protocol
Length of output: 3911
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 3064
🏁 Script executed:
# Look for enum Cmd or command constants ast-grep outline lib/src/control.dartRepository: OpenStrap/protocol
Length of output: 191
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 5842
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 4680
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 607
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 7139
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 8237
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 168
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 1066
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 645
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 653
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 1329
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 575
🏁 Script executed:
Repository: OpenStrap/protocol
Length of output: 156
Confirm the layout with hardware before publishing
req_seqat inner[3].The packet structure is
[packet_type][seq][opcode][body…], placinginner[3]as the first body byte. The code confirms this:payload = Uint8List.sublistView(inner, 3)makespayload[0]equal toinner[3]. Multiple parsers read this byte as body data. GET_ALARM_TIME readspayload[0](inner[3]) as a form indicator (0x01 or 0x04); the body location parser expects it as a revision field (0x01). Publishing this byte asreq_seqexposes body data as correlation metadata unless the hardware differs from the documented layout.The code acknowledges (line 440): "it is not confirmed against a hardware capture here." Verify the layout against a real captured response or add opcode-specific gating. If only certain commands echo a request sequence, restrict
req_seqto those opcodes only. Keep the field absent when correlation cannot be reliably established.🤖 Prompt for AI Agents
Source: MCP tools