Skip to content

[ENHANCEMENT] make operating_status optional #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victor Schappert (vcschapp) merged 2 commits into from
May 6, 2026
Merged

[ENHANCEMENT] make operating_status optional #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a114c
make operating status optional
jeffdefacto May 6, 2026
1065dc3
Make operating status optional
jeffdefacto May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/overture-schema-places-theme/src/overture/schema/places/place.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,10 @@ class Place(OvertureFeature[Literal["places"], Literal["place"]], Named):
),
]

# Required
# Optional

operating_status: Annotated[
OperatingStatus,
OperatingStatus | None,
Field(
description=textwrap.dedent("""
An indication of whether a place is: in continued operation, in a temporary
Expand All @@ -221,9 +221,7 @@ class Place(OvertureFeature[Literal["places"], Literal["place"]], Named):
set to 0.
""").strip(),
),
]

# Optional
] = None

categories: Categories | None = None
basic_category: Annotated[
Expand Down
3 changes: 1 addition & 2 deletions packages/overture-schema-places-theme/tests/place_baseline_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,7 @@
"required": [
"theme",
"type",
"version",
"operating_status"
"version"
],
"type": "object"
},
Expand Down
1 change: 0 additions & 1 deletion schema/places/place.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,3 @@ properties:
This is not an indication of 'opening hours' or that the place is open/closed at the current time-of-day or day-of-week.
type: string
enum: ["open", "permanently_closed", "temporarily_closed"]
required: [operating_status]
Loading