SeedReport: Saving & Replaying RNG seed capability. - #378
Open
drewconnelly-qntm wants to merge 8 commits into
Open
SeedReport: Saving & Replaying RNG seed capability.#378drewconnelly-qntm wants to merge 8 commits into
SeedReport: Saving & Replaying RNG seed capability.#378drewconnelly-qntm wants to merge 8 commits into
Conversation
Testing the following: - tests seedreport data saving correctly - tests determinism when seeds are the same, and disagreement when seeds are not - tests agreement between a job and the re-running of that job - tests loading a seed report from json and string, as well as failure when no file exists to import from.
Collaborator
|
I haven't looked closely but just skimming things: You might want to see if you can do this without using an Arc Mutex. They are slightly expensive. |
Collaborator
Author
Thanks, I'll check on how necessary that is. |
It was annoying the lint checker.
drewconnelly-qntm
marked this pull request as ready for review
July 28, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
In
crates/pecos-engines/src/monte_carlo/engine.rs:SeedReportwhich stores the RNG seed information for a monte carlo runrun_with_workers_seed_reportwhich runs a monte carlo job with workers, while managing the RNG seeds with a seed report. Has a bool option to save the report to a JSON namesseed_report.json.WorkerSeedRecordwhich stores the worker index, num shots, and seed for that worker, which is what is held in a vector inside the overall job'sSeedReportfor each monte carlo job.SeedReportto JSON as well as loading them from JSON.Potential Future Work:
Testing:
cargo test -p pecos-engineswas all goodjust build; just testran through the rust tests fine but had issues with the python pytests due to some bugs with my environment locally.