Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. Walkthrough이 PR은 날짜 범위 포맷터 메서드명을 Changes
Sequence Diagram(s)(생성 조건 미충족 — 생략) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/main/java/com/permitseoul/permitserver/global/util/LocalDateTimeFormatterUtil.java`:
- Around line 16-17: There is a stray orphan fragment causing a syntax error
after the DAY_FORMATTER declaration; either remove the leftover
"Locale.ENGLISH); // May 2025" fragment entirely or restore the intended
MONTH_YEAR_FORMATTER declaration (e.g., define MONTH_YEAR_FORMATTER =
DateTimeFormatter.ofPattern("MMM yyyy", Locale.ENGLISH)) so the class compiles;
update the code around DAY_FORMATTER and MONTH_YEAR_FORMATTER to ensure every
DateTimeFormatter declaration is a complete, valid statement.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/main/java/com/permitseoul/permitserver/global/util/LocalDateTimeFormatterUtil.java`:
- Around line 27-53: The method formatStartEndDate currently dereferences
startDate and endDate which can cause NullPointerException; update
formatStartEndDate to validate inputs at the start (e.g., call
Objects.requireNonNull(startDate, "startDate must not be null") and
Objects.requireNonNull(endDate, "endDate must not be null")) or annotate
parameters with `@NonNull` and add equivalent validation, so the method fails fast
with clear messages instead of throwing NPEs later; reference the
formatStartEndDate method and the startDate/endDate parameters when applying the
change.
♻️ Duplicate comments (1)
src/main/java/com/permitseoul/permitserver/global/util/LocalDateTimeFormatterUtil.java (1)
16-25: LGTM! 이전 컴파일 오류가 해결되었습니다.포맷터 상수들이 올바르게 선언되었으며, 이전 리뷰에서 지적된 고아 코드 조각 문제가 수정되었습니다.
EN_DASH에 유니코드 en-dash (U+2013)를 사용한 것은 타이포그래피적으로 올바른 선택입니다.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/main/java/com/permitseoul/permitserver/global/util/LocalDateTimeFormatterUtil.java`:
- Around line 28-58: formatStartEndDate currently always uses endDate's year
(variable year) which mislabels ranges spanning years; compute startYear and
endYear via startDate.format(YEAR_FORMATTER) and endDate.format(YEAR_FORMATTER)
and branch: if startDate.toLocalDate().equals(endDate.toLocalDate()) keep the
existing single-year formatting (use either year), else if
startYear.equals(endYear) keep the current behavior (append one year at the
end), otherwise when years differ append the startYear after startMonthDay and
the endYear after endMonthDay (e.g., "Jan 31, 2025 – Jan 1, 2026") using the
existing MONTH_DAY_FORMATTER, DAY_FORMATTER, COMMA_AND_SPACE and EN_DASH symbols
in LocalDateTimeFormatterUtil.formatStartEndDate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨 참고 사항