Lazy scipy imports#486
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 75.43% 75.33% -0.11%
==========================================
Files 62 62
Lines 6901 6946 +45
Branches 1229 1229
==========================================
+ Hits 5206 5233 +27
- Misses 1223 1241 +18
Partials 472 472 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dilpath
approved these changes
Jun 9, 2026
Comment on lines
+335
to
+342
| try: | ||
| from scipy.stats import norm | ||
| except ImportError as e: | ||
| raise ImportError( | ||
| "scipy is required for this functionality. " | ||
| "Install it with: pip install scipy" | ||
| ) from e | ||
| self._dist = norm |
Member
Author
There was a problem hiding this comment.
The current way enables better static analysis which I'd prefer here. I'll dereplicate the message, though.
For now, keep scipy optional, unless probability distributions are really needed. Fixes PEtab-dev#483.
dweindl
force-pushed
the
fix_483_lazy_stats
branch
from
094b235 to
7ce0bdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, keep scipy optional, unless probability distributions are really needed.
Fixes #483.