Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions grammars/prql-lezer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ A Lezer / CodeMirror grammar for PRQL. It's largely fully-functioning, with a
few small TODOs in the [grammar file](src/prql.grammar).

CodeMirror grammars are required by some downstream tools, including
[Jupyter syntax highlighting](https://github.com/PRQL/pyprql/issues/45). As of
2022-12 none yet use it.
[Jupyter syntax highlighting](https://github.com/PRQL/pyprql/issues/45).

We don't yet have the JS machinery around it, and it's not published to any
package managers. We can add that shortly. Possibly it'll go into its own repo.

## Developing

Given there aren't yet tests, we've been developing this by:
Tests are in the `test/` directory. The Lezer playground can also be useful for
interactive development:

- Opening <https://lezer-playground.vercel.app/>
- Pasting an example query
Expand Down
2 changes: 1 addition & 1 deletion prqlc/prqlc-parser/src/lexer/lr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ impl std::fmt::Display for TokenKind {
TokenKind::Coalesce => f.write_str("??"),
TokenKind::DivInt => f.write_str("//"),
TokenKind::Pow => f.write_str("**"),
TokenKind::Annotate => f.write_str("@{"),
TokenKind::Annotate => f.write_str("@"),

TokenKind::Param(id) => write!(f, "${id}"),

Expand Down
2 changes: 1 addition & 1 deletion prqlc/prqlc/src/semantic/resolver/transforms.rs
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ impl Lineage {

// special case: include a tuple
if expr.ty.as_ref().is_some_and(|x| x.kind.is_tuple()) && expr.kind.is_ident() {
// this ident is a tuple, which means it much point to an input
// this ident is a tuple, which means it must point to an input
let input_id = expr.target_id.unwrap();

self.columns.push(LineageColumn::All {
Expand Down
Loading