chore: bump lsp-server from 0.8.0 to 0.10.0 - #6134
Conversation
Bumps [lsp-server](https://github.com/rust-lang/rust-analyzer) from 0.8.0 to 0.10.0. - [Release notes](https://github.com/rust-lang/rust-analyzer/releases) - [Commits](https://github.com/rust-lang/rust-analyzer/commits) --- updated-dependencies: - dependency-name: lsp-server dependency-version: 0.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
lsp-server 0.10 replaced `Response`'s `result`/`error` fields with a single `response_result: Result<Value, ResponseError>`. Use the `Response::new_ok` constructor, which also handles serialization.
prql-bot
left a comment
prql-bot
left a comment
There was a problem hiding this comment.
The code change itself is correct: Response's result/error fields were replaced by a single response_result: Result<Value, ResponseError> in 0.10, and Response::new_ok(id, result) does exactly what the old code did (it calls serde_json::to_value(result).unwrap() internally), so the wire output is unchanged. cargo check -p prqlc --features lsp passes locally on the merged tree.
One thing worth a maintainer decision before merging: lsp-server 0.10.0 is edition = "2024", which requires Rust 1.85+, while the workspace declares rust-version = "1.81.0" (and prqlc/prqlc/Cargo.toml carries metadata.msrv = "1.81.0" for cargo-msrv). So after this bump, anything that enables the lsp feature — task lint (cargo clippy --all-targets --all-features) and task build-all — no longer builds on the declared MSRV.
CI won't surface it: the test-msrv job runs cargo msrv verify with no feature flags, so the optional lsp-server dependency is never compiled there, and no other job enables lsp. lsp-server 0.10.0 also doesn't declare a rust-version, so cargo's MSRV-aware resolver can't reject it either.
Options as I see them: accept it (the lsp feature is a stub and off by default, and contributors are realistically on recent stable), bump the workspace MSRV to 1.85, or hold at 0.8. I don't think a bot should pick between those, hence a comment rather than an approval.
Unrelated to the diff: build-prqlc (windows-latest, x86_64-pc-windows-msvc, default) failed with Failed to FinalizeArtifact: Received non-retryable error: Failed request: (404) Not Found: artifact not found — an Actions artifact-upload flake, not a compile error. That job builds default features, which don't include lsp. I'll re-run it once the workflow finishes.
|
pre-commit.ci run |
2 participants
Bumps lsp-server from 0.8.0 to 0.10.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)