Change default stationarized to False in plot_aggregates - #1183
Open
arihantlodha-cmd wants to merge 1 commit into
Open
Change default stationarized to False in plot_aggregates#1183arihantlodha-cmd wants to merge 1 commit into
stationarized to False in plot_aggregates#1183arihantlodha-cmd wants to merge 1 commit into
Conversation
Closes PSLmodels#1133. Plots unstationarized percentage changes by default, giving a more consistent view of aggregate changes when baseline and reform have different underlying growth rates (and identical output when they match).
Member
|
@arihantlodha-cmd: good catch. Yes, please change |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
=========================================
Coverage ? 72.66%
=========================================
Files ? 22
Lines ? 5725
Branches ? 0
=========================================
Hits ? 4160
Misses ? 1565
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1133.
Changes the default
stationarizedargument inoutput_plots.plot_aggregatesfromTruetoFalse, so unstationarized percentage changes are plotted by default. As noted in the issue, this produces identical output when the baseline and reform share the same underlying growth rates, and a more consistent view of aggregate changes when they don't.Testing
pytest tests/test_output_plots.py→ 50 passedruff format --check .andruff check .→ cleanOne question for maintainers:
plot_industry_aggregatesin the same module also defaults tostationarized=True. I left it unchanged since the issue only mentionsplot_aggregates— happy to flip it here too if you'd like the two kept consistent.