Skip to content

Add logging to IncentiveServiceImpl methods #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kunxal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add logging to IncentiveServiceImpl methods #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7324ec9
Add logging to IncentiveServiceImpl methods
Kunxal Apr 3, 2026
63f4241
Handle null values in activityDTOS string concatenation
Kunxal Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/main/java/com/iemr/flw/service/impl/IncentiveServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,20 @@
import com.iemr.flw.repo.iemr.IncentivesRepo;
import com.iemr.flw.service.IncentiveService;
import org.modelmapper.ModelMapper;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
import java.util.stream.Collectors;

@Service
public class IncentiveServiceImpl implements IncentiveService {

private final Logger logger = LoggerFactory.getLogger(IncentiveServiceImpl.class);

ModelMapper modelMapper = new ModelMapper();

Expand All @@ -46,11 +50,15 @@ public String saveIncentivesMaster(List<IncentiveActivityDTO> activityDTOS) {
}
incentivesRepo.save(activity);
});
String saved = "";
activityDTOS.forEach(dto -> saved.concat(dto.getGroup() + ": " + dto.getName()));
return "saved master data for " + saved ;
StringBuilder saved = new StringBuilder();
activityDTOS.forEach(dto -> saved.append(Objects.toString(dto.getGroup(), "")).append(": ").append(Objects.toString(dto.getName(), "")).append(", "));
// Remove trailing ", " if present
if (saved.length() > 0) {
saved.setLength(saved.length() - 2);
}
return "saved master data for " + saved.toString();
} catch (Exception e) {

logger.error("Error saving incentive master data: " + e.getMessage(), e);
}
return null;
}
Expand All @@ -66,7 +74,7 @@ public String getIncentiveMaster(IncentiveRequestDTO incentiveRequestDTO) {
Gson gson = new GsonBuilder().setDateFormat("MMM dd, yyyy h:mm:ss a").create();
return gson.toJson(dtos);
} catch (Exception e) {

logger.error("Error getting incentive master data: " + e.getMessage(), e);
}
return null;
}
Expand Down