Skip to content

Secure file download via API proxy instead of credential-exposed URL#146

Open
vishwab1 wants to merge 2 commits intorelease-3.6.2from
vb/filedownload
Open

Secure file download via API proxy instead of credential-exposed URL#146
vishwab1 wants to merge 2 commits intorelease-3.6.2from
vb/filedownload

Conversation

@vishwab1
Copy link
Copy Markdown
Member

@vishwab1 vishwab1 commented Apr 7, 2026

📋 Description

JIRA ID: AMM-2234
AMM-2233

Please provide a summary of the change and the motivation behind it. Include relevant context and details.


  • TM-API now downloads files from OpenKM server-side and returns base64 content with original fileName
  • TM-UI decodes base64 and triggers browser download with correct file name
  • OpenKM credentials no longer exposed to the browser

✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

vishwab1 and others added 2 commits April 7, 2026 17:25
API now downloads file from OpenKM server-side and returns base64
instead of the URL with embedded credentials that browsers block.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add getFileName query to fetch original fileName from t_kmfilemanager
- Return JSON with fileContent (base64) and fileName instead of raw base64

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80e6fedc-e370-4234-a4e7-2a48d657d6c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vb/filedownload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vishwab1 vishwab1 requested a review from vanitha1822 April 7, 2026 12:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant