Skip to content

chore: modernize - #23

Open
Timongcraft wants to merge 19 commits into
PaperMC:masterfrom
Timongcraft:chore/modernize
Open

chore: modernize#23
Timongcraft wants to merge 19 commits into
PaperMC:masterfrom
Timongcraft:chore/modernize

Conversation

@Timongcraft

@Timongcraft Timongcraft commented Jun 29, 2025

Copy link
Copy Markdown

chore: modernize build script
chore: move to unobfuscation (also means 26.1+ only)
feat: add tests
feat: add github build & test workflow
chore: bump versions
chore: up license year
chore: update readme
-> closes: #15

chore: move to kts
 -> move to libs.versions
chore: move to mojm
chore: bump versions
 -> gradle wrapper
 -> loom
 -> project version
chore: update readme
feat: update to 26.1-snapshot-5
chore: update gradle to 9.3.1
chore: up license year
-> re-add placeholder todo
@Timongcraft
Timongcraft marked this pull request as ready for review March 19, 2026 20:26
Comment thread src/main/resources/fabric.mod.json Outdated
Comment thread settings.gradle.kts
Timongcraft and others added 2 commits May 25, 2026 21:00
Co-authored-by: Emil <12966472+Emilxyz@users.noreply.github.com>
@suerion

suerion commented May 26, 2026

Copy link
Copy Markdown

Had tested yesterday this pull, it work on 26.1.2

but, if no proxy is given, it hooks into the commands and the client could not connect anymore
https://mclo.gs/bCa5cJg

you should handle this with an error, that CrossStitch is not needed and bring errors with it, if that would not used with an proxy

@Timongcraft

Copy link
Copy Markdown
Author

Had tested yesterday this pull, it work on 26.1.2

but, if no proxy is given, it hooks into the commands and the client could not connect anymore mclo.gs/bCa5cJg

you should handle this with an error, that CrossStitch is not needed and bring errors with it, if that would not used with an proxy

Well that was always the case and without proper proxy-backend communication, which isn't present for various reasons, we can't properly add a fallback for that.
What we can do is check for FabricProxy-Lite and if it is not present don't run.
And provide some kind of hook so other mods can force CrossStitch. (Will look into mixin configs later)

@Timongcraft

Copy link
Copy Markdown
Author

If we'd require FabricProxy-Lite though, we undermine the ability to not use any forwarding.
IMO the modpage description is enough and anyone else we be helped in an issue. (Or Discord if it's going to be linked)

 -> bump fabric stuff (require at least 26.1.2 instead of 26.1)
 -> bump gradle
 -> bump gh actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete install doc

3 participants