Fix data component conversion in CraftEntity throwing a ClassCastException#14099
Open
TheZexquex wants to merge 2 commits into
Open
Fix data component conversion in CraftEntity throwing a ClassCastException#14099TheZexquex wants to merge 2 commits into
TheZexquex wants to merge 2 commits into
Conversation
Contributor
|
There's no reason to use FQN in .java files, those are used only in .patch files to avoid extra diff from imports (other FQN are from pre-hardfork) |
| } | ||
|
|
||
| public static <B, M> @Nullable B convertDataComponentValue(final DataComponentMap map, final PaperDataComponentType.ValuedImpl<B, M> type) { | ||
| public static <B, M> @Nullable B convertDataComponentValue(final net.minecraft.core.component.DataComponentGetter getter, final PaperDataComponentType.ValuedImpl<B, M> type) { |
Member
There was a problem hiding this comment.
can this not just be imported or was there a conflict?
Author
There was a problem hiding this comment.
Yes it can be imported, I just used the fqn because I used it in CraftEntity (where I used it because it was done everywhere else), I'll change it real quick
Doc94
approved these changes
Jul 24, 2026
electronicboy
approved these changes
Jul 24, 2026
papermc-projects
Bot
moved this from Awaiting review
to Full approval
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes wrong crasting in CraftEntity for data components. Closes Issue #14090