Skip to content

Fix handshake hostname length limit and plugin message drop during join#1783

Open
SendableMetatype wants to merge 1 commit intoPaperMC:dev/3.0.0from
SendableMetatype:dev/3.0.0
Open

Fix handshake hostname length limit and plugin message drop during join#1783
SendableMetatype wants to merge 1 commit intoPaperMC:dev/3.0.0from
SendableMetatype:dev/3.0.0

Conversation

@SendableMetatype
Copy link
Copy Markdown

  • Remove restrictive handshake hostname length limit: The 261-character MAXIMUM_HOSTNAME_LENGTH in HandshakePacket.decode() silently disconnects clients when enough plugins inject forwarding data into the hostname field that the combined length exceeds the limit. readString(buf) now uses the default 65536 limit, matching every other string field and aligning with Paper/Spigot's equivalent fix (readUtf(255) to readUtf(Short.MAX_VALUE) in ClientIntentionPacket).

  • Fix plugin messages silently dropped during player join: Fixes Plugin messages silently dropped during player join when getConnectedServer() is null #1766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin messages silently dropped during player join when getConnectedServer() is null

1 participant