Fix handshake hostname length limit and plugin message drop during join#1783
Open
SendableMetatype wants to merge 1 commit intoPaperMC:dev/3.0.0from
Open
Fix handshake hostname length limit and plugin message drop during join#1783SendableMetatype wants to merge 1 commit intoPaperMC:dev/3.0.0from
SendableMetatype wants to merge 1 commit intoPaperMC:dev/3.0.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove restrictive handshake hostname length limit: The 261-character
MAXIMUM_HOSTNAME_LENGTHinHandshakePacket.decode()silently disconnects clients when enough plugins inject forwarding data into the hostname field that the combined length exceeds the limit.readString(buf)now uses the default 65536 limit, matching every other string field and aligning with Paper/Spigot's equivalent fix (readUtf(255)toreadUtf(Short.MAX_VALUE)inClientIntentionPacket).Fix plugin messages silently dropped during player join: Fixes Plugin messages silently dropped during player join when getConnectedServer() is null #1766