Skip to content

web: apply frontend review fixes - #95

Merged
jpenilla merged 1 commit into
masterfrom
frontend-review-fixes
Aug 6, 2026
Merged

web: apply frontend review fixes#95
jpenilla merged 1 commit into
masterfrom
frontend-review-fixes

Conversation

@jpenilla

@jpenilla jpenilla commented Aug 6, 2026

Copy link
Copy Markdown
Member

Applies frontend review feedback for the web interface.

Auth & routing

  • Replace onMount-based auth redirects with prerender-safe +page.ts load guards:
    //login when no token, /login/ when a token exists. Removes the
    flash of the dashboard before redirect.
  • Drop the redundant token check from login/+page.svelte.

API & state

  • Simplify fetchApi: relative URLs, drop dead headers spread, correctly merge
    Authorization with caller-provided headers, and fix query-string construction.
  • Use the reactive token state instead of direct localStorage reads.
  • URL-encode the Minecraft version in API requests.

Components & accessibility

  • Fix PatchesStats stuck on "Loading statistics…" when total === 0.
  • Fix duplicated dark:dark:bg-white/20 Tailwind class.
  • Add a11y: role="progressbar" + ARIA values on the stats bar, aria-pressed
    on the Table/Stats toggles, and autocomplete on the login inputs.
  • Clean up LabeledCheckbox, SettingsPopoverGroup, PatchesTable, and
    theme.svelte.ts (dead snippets/script/style blocks, unused snippet params,
    SSR-safety note).

Notes

  • getUsername() keeps its original throw-on-missing-token behavior; the
    dashboard guards display with a ternary.
  • Verified with bun run check, bun run lint, and bun run build, plus a
    manual end-to-end pass against a local backend (login, dashboard, stats,
    logout redirects).

@jpenilla
jpenilla merged commit b4618ee into master Aug 6, 2026
@jpenilla
jpenilla deleted the frontend-review-fixes branch August 6, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant