Skip to content

Fix flaky ASB tests #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbev merged 7 commits into from
Jul 21, 2026
Merged

Fix flaky ASB tests #5621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f13c7a
Update error handling in action
rbev Jul 20, 2026
cb3e280
Pin AZ cli
rbev Jul 20, 2026
b57dc68
Try a differnt method of pinning az
rbev Jul 20, 2026
660e219
Also pin the container test az cli
rbev Jul 20, 2026
59c9b4e
Missing quotes
rbev Jul 20, 2026
8cb2c09
Use correct version of action
rbev Jul 20, 2026
62329e3
Potential fix for pull request finding
rbev Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,23 @@ jobs:
- name: Smoke test PowerShell module import
if: matrix.os-name == 'Windows'
run: Import-Module ./deploy/PowerShellModules/Particular.ServiceControl.Management

# there is an issue with az cli and python 3.14, so for now we need to pin it
# once the issue is resolved it should be able to be re-floated
Comment thread
rbev marked this conversation as resolved.
# https://github.com/Azure/azure-cli/issues/32980
- name: Set Python 3.13 (Linux)
if: matrix.os-name == 'Linux' && matrix.test-category == 'AzureServiceBus'
uses: actions/setup-python@v5
with:
python-version: '3.13'
- name: Install pinned Azure CLI on Python 3.13 (Linux)
if: matrix.os-name == 'Linux' && matrix.test-category == 'AzureServiceBus'
shell: bash
run: |
python -m pip install --upgrade pip
python -m pip install --user "azure-cli==2.64.0"
echo "$HOME/.local/bin" >> "$GITHUB_PATH"

- name: Azure login
uses: azure/login@v3.0.0
if: matrix.test-category == 'AzureServiceBus' || matrix.test-category == 'AzureStorageQueues' || matrix.test-category == 'RabbitMQ' || matrix.test-category == 'PostgreSQL'
Expand Down Expand Up @@ -92,7 +109,7 @@ jobs:
registry-username: ${{ secrets.DOCKERHUB_USERNAME }}
registry-password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Setup Azure Service Bus
uses: Particular/setup-azureservicebus-action@v2.3.0
uses: Particular/setup-azureservicebus-action@v2.4.0
if: matrix.test-category == 'AzureServiceBus'
with:
connection-string-name: ServiceControl_TransportTests_ASBS_ConnectionString
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/container-integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,23 @@ jobs:
uses: actions/setup-dotnet@v6.0.0
with:
global-json-file: global.json

# there is an issue with az cli and python 3.14, so for now we need to pin it
# once the issue is resolved it should be able to be re-floated
# https://github.com/Azure/azure-cli/issues/32980
- name: Set Python 3.13 (Linux)
if: matrix.name == 'asb'
uses: actions/setup-python@v5
with:
python-version: '3.13'
- name: Install pinned Azure CLI on Python 3.13 (Linux)
if: matrix.name == 'asb'
shell: bash
run: |
python -m pip install --upgrade pip
python -m pip install --user "azure-cli==2.64.0"
echo "$HOME/.local/bin" >> "$GITHUB_PATH"

- name: Run MinVer
uses: Particular/run-minver-action@v1.0.0
- name: Log in to GitHub container registry
Expand Down
Loading