Add persistence and replay for failed error imports - #5656
Merged
Conversation
rbev
approved these changes
Jul 28, 2026
| return buffer.ToArray(); | ||
| } | ||
|
|
||
| // The row is removed before its external body: a surviving row with a missing body would replay |
Contributor
There was a problem hiding this comment.
If you wanted to avoid this leak you could change it to flag the row as replayed and then delete in the other order.
Member
Author
There was a problem hiding this comment.
I am not sure this is going to be an issue at all.
I am going to leave it for now.
johnsimons
force-pushed
the
john/ef_ingestion_failure
branch
from
July 28, 2026 06:29
f556664 to
01755b3
Compare
Introduces a new persistence mechanism for error messages that failed during their initial ingestion into ServiceControl. This ensures that these messages are reliably stored and can be re-processed at a later time. The new `FailedErrorImports` table stores the failed messages, including their headers, body, and exception information. A deduplication mechanism ensures that repeated failures of the same message only update the existing record with the latest details.
warwickschroeder
approved these changes
Jul 28, 2026
johnsimons
enabled auto-merge
July 28, 2026 23:35
johnsimons
force-pushed
the
john/ef_ingestion_failure
branch
from
July 28, 2026 23:40
64c73d2 to
eaea6f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new persistence mechanism for error messages that failed during their initial ingestion into ServiceControl. This ensures that these messages are reliably stored and can be re-processed at a later time.
The new
FailedErrorImportstable stores the failed messages, including their headers, body, and exception information. A deduplication mechanism ensures that repeated failures of the same message only update the existing record with the latest details.