Split up sql dialects by consuming store - #5702
Open
rbev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the SQL dialect and ingestion infrastructure for both PostgreSQL and SQL Server providers, separating the logic for failed message ingestion and retry batch persistence into distinct, provider-specific classes. This change clarifies responsibilities, improves maintainability, and enables more granular testing. It also introduces shared base classes for common SQL generation and execution logic.
Functional changes:
Refactoring of SQL dialects and ingestion infrastructure:
PostgreSqlDialect,SqlServerDialect) to encapsulate common SQL parameterization and execution logic, reducing code duplication. [1] [2]IFailedMessageIngestionSqlDialectandIRetryBatchSqlDialectinterfaces, with separate implementations for PostgreSQL (PostgreSqlFailedMessageIngestionSqlDialect,PostgreSqlRetryBatchSqlDialect) and SQL Server (SqlServerFailedMessageIngestionSqlDialect,SqlServerRetryBatchSqlDialect). [1] [2] [3]Documentation updates:
docs/error-ingestion-design.mdto reflect the new separation of dialect responsibilities, clarifying which classes are responsible for which persistence operations. [1] [2] [3]