Move Raven ID out of persisence contract - #5705
Open
rbev wants to merge 2 commits into
Open
Conversation
rbev
force-pushed
the
rhys/notifications
branch
from
August 6, 2026 09:15
0dc2f39 to
735dd16
Compare
rbev
marked this pull request as ready for review
August 7, 2026 00:55
rbev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current Notifications data store is stored as a singleton document in RavenDB, and is returned directly from the INotificationsManager. The Id field on this document is not used or relevant to consumers of this interface.
To remove this field from the contract this change implements a new internal class for Raven to persist, and removes the ID field from the returned object.
Testing Improvements:
NotificationsDataStoreTestswith comprehensive tests to verify default values, round-trip persistence, field updates, and field preservation for notification settings. (src/ServiceControl.Persistence.Tests/NotificationsDataStoreTests.cs)