fix: Add explicit OrderedCollections and DequeModule imports for Swift 6.3#3
Merged
Merged
Conversation
…t 6.3 EventLoopConnectionPool uses members of OrderedCollections and DequeModule (the OrderedDictionary and Deque backing storage), but the modules were not imported explicitly. With the MemberImportVisibility upcoming feature enabled, Swift 6.3 rejects the implicit member access, so the package fails to build. Add the two explicit imports. Co-authored-by: Scott Marchant <scottm@passivelogic.com>
scottmarchant
self-requested a review
July 21, 2026 16:26
scottmarchant
approved these changes
Jul 21, 2026
Collaborator
|
Note that we expect some test failures for a bit until we fix things up. Subsequent PR #2 is expected to fix CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
mainenables theMemberImportVisibilityupcoming feature but never importsDequeModuleorOrderedCollectionsexplicitly, even thoughEventLoopConnectionPooluses their members (theDeque/OrderedDictionarybacking storage). Under Swift 6.3, which enforces the feature, the implicit member access is rejected and the package fails to build. This adds the two explicit imports.Independent of any wasm work - it fixes the plain Swift 6.3 build. Needed first so the API-breakage baseline (which builds
main) can compile.Links
What changed
Sources/AsyncKit/ConnectionPool/EventLoopConnectionPool.swift- add explicitimport DequeModuleandimport OrderedCollections.Tested
swift build